Add a debug B compset test with the standard configuration, and tests with aoflux_grid = agrid and ogrid#330
Merged
fischer-ncar merged 3 commits intoESCOMP:cesm3.0-alphabranchfrom Apr 11, 2025
Conversation
Add a short debug B compset test with the standard configuration, along with companion tests covering aoflux_grid=ogrid and aoflux_grid=agrid rather than the now-default aoflux_grid=xgrid.
Trying to use ATM_NCPL leads to: ERROR: assume that rof_cpl_time is always greater than or equal to ocn_cpl_time
It didn't work to do 7-hour ERS tests: this led to failures in the comparisons of some MOM output files. (I didn't look into this carefully, but at a glance, it looks like it was comparing the file from the initial time, I guess because that was the only one available.) I want a debug ERS test of the standard configuration, so I'm keeping that but lengthening it to 3 days. For the agrid and ogrid, it doesn't seem worth the compute time to make these ERS tests, because I'm not sure that there is any different restart-related code covered for these compared with the standard configuration; so I'm changing those to 1-day SMS tests. (It would probably work to make them less than a day, but making them 1 day lets us output component history files and avoid changing coupling frequencies for any components.)
fischer-ncar
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
My main motivation was adding tests with aoflux_grid = agrid and aoflux_grid = ogrid so that we continue to test those options now that the default is xgrid. However, in adding these, I noticed that we didn't have any debug B compset tests in the prealpha or prebeta test suites, so I also added one of those.
Specific notes
Contributors other than yourself, if any: none
Fixes: none
User interface changes?: No
Testing performed (automated tests and/or manual tests): Ran the new tests and verified that they pass
More detailed notes
My original plan was to do 7-hour ERS_D tests for these three configurations (standard configuration with xgrid; ogrid; agrid) (note that I introduced a new testmod to support these short tests: see an earlier commit in the history of this branch), but this caused problems in MOM:
call ESMF_GridCompGetInternalState(gcomp, ocean_internalstate, rc)andocean_state => ocean_internalstate%ptr%ocean_state_type_ptrto outside thedo_advanceconditional so thatocean_statewould be associated in the restart code.@alperaltuntas - it seems like it might be worth resolving these issues at some point so that we can run shorter tests with MOM, but it doesn't feel urgent.
I decided to keep an ERS_D test of the standard configuration, lengthening it to 3 days to get around the MOM issues with shorter tests. It felt unnecessary to have an ERS test of agrid / ogrid, because my sense is that these different aoflux calculations don't seem to do anything with restart files (so there is no additional code coverage from having restart as opposed to smoke tests of those options, given that we have a restart test of the default xgrid option), so I introduced 1-day SMS tests of those. (However, I did run
ERS_D_Ld3.ne30pg3_t232.BLT1850.derecho_intel.allactive-aoflux_ogridandERS_D_Ld3.ne30pg3_t232.BLT1850.derecho_intel.allactive-aoflux_agridand verified that they currently pass.)I spot-checked a few aoflux variables in the cpl hist file in the above two tests (agrid/ogrid) vs the original (xgrid); they look roughly similar in all 3 cases but not identical, as expected. I didn't do a careful investigation of this, though.
@mvertens and @jedwards4b - keeping you in the loop with these added tests. (Mariana, we exchanged some emails about this a few months ago but I'm just getting around to it now.)