Skip to content

ctsm5.4.019: Fix years used by generate_gdds#3749

Merged
samsrabin merged 23 commits intoESCOMP:masterfrom
samsrabin:update-generate_gdds-cleaner4
Feb 13, 2026
Merged

ctsm5.4.019: Fix years used by generate_gdds#3749
samsrabin merged 23 commits intoESCOMP:masterfrom
samsrabin:update-generate_gdds-cleaner4

Conversation

@samsrabin
Copy link
Member

@samsrabin samsrabin commented Feb 10, 2026

Description of changes

This fixes a bug where generate_gdds was looking for the wrong timestamps.

Does not change answers in any aux_clm tests, but does change answers from the tool and in the rxcropmaturity suite, so should go to master instead of b4b-dev.

Specific notes

Contributors other than yourself, if any: None

CTSM Issues Fixed:

Are answers expected to change (and if so in what way)? Yes, when using the generate_gdds tool.

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any: As of ff69336:

  • Python unit tests
  • Python system tests
  • Python black and linting
  • rxcropmaturity suite
  • clm_pymods suite

@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone Feb 10, 2026
@samsrabin samsrabin self-assigned this Feb 10, 2026
@samsrabin samsrabin added non-bfb Changes answers (incl. adding tests) test: python Pass clm_pymods test suite plus Python sys/unit tests before merging test: aux_clm Pass aux_clm suite before merging labels Feb 10, 2026
@samsrabin samsrabin force-pushed the update-generate_gdds-cleaner4 branch from 22f74c2 to fc59eca Compare February 10, 2026 21:56
samsrabin and others added 5 commits February 10, 2026 16:10
Doesn't really matter, but just for clarity, since we expect only annual h1 files but daily h2 files.
Was redundant with _t232 version of f09 RXCROPMATURITY_ test, which is now preferred.
@samsrabin samsrabin force-pushed the update-generate_gdds-cleaner4 branch from fc59eca to 31af968 Compare February 10, 2026 23:11
@github-project-automation github-project-automation bot moved this to Ready to start (or start again) in CTSM: Upcoming tags Feb 11, 2026
@samsrabin samsrabin moved this from Ready to start (or start again) to In progress - master in CTSM: Upcoming tags Feb 11, 2026
@samsrabin samsrabin marked this pull request as ready for review February 11, 2026 18:21
Copy link
Contributor

@slevis-lmwg slevis-lmwg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samsrabin and I did a detailed walkthrough.
@samsrabin will resolve things that came up in the walkthrough.

@samsrabin samsrabin changed the title Fix years used by generate_gdds ctsm5.4.0xx: Fix years used by generate_gdds Feb 12, 2026
@samsrabin samsrabin changed the title ctsm5.4.0xx: Fix years used by generate_gdds ctsm5.4.019: Fix years used by generate_gdds Feb 12, 2026
samsrabin and others added 2 commits February 12, 2026 12:17
Quick fix so that we can use ndep sent from ATM

Add the ndep_inparm namelist to drv_flds_in, so that CTSM can turn on ndep from the ATM model. Also turn on using the ndep from the ATM model for the cam LndTuningMode testmods. And make sure ndep comes from CAM when we are coupled to CAM.
@samsrabin samsrabin removed the test: aux_clm Pass aux_clm suite before merging label Feb 13, 2026
@samsrabin samsrabin merged commit d935a68 into ESCOMP:master Feb 13, 2026
6 checks passed
@github-project-automation github-project-automation bot moved this from In progress - master to Done (non release/external) in CTSM: Upcoming tags Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

non-bfb Changes answers (incl. adding tests) test: python Pass clm_pymods test suite plus Python sys/unit tests before merging

Projects

Status: Done (non release/external)

Development

Successfully merging this pull request may close these issues.

RXCROPMATURITY tests broken

2 participants