Changes after rename of CCPPStandardNames --> ESMStandardNames #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mkavulich
commented
Mar 4, 2025
mkavulich
commented
- Remove references to CCPP except where relevant
- Cherry-pick changes to tools/write_standard_name_table.py from release branch that allows for subsections in standard names and markdown table
- Group CCPP-specific variables into a dedicated section
- Change some long_name descriptions to remove CCPP-specific wording
- A few more details in README.md
- Remove references to CCPP except where relevant - Cherry-pick changes to tools/write_standard_name_table.py from release branch that allows for subsections in standard names and markdown table - Group CCPP-specific variables into a dedicated section - Change some long_name descriptions to remove CCPP-specific wording - A few more details in README.md
mkavulich
requested review from
MayeulDestouches,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mattldawson,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
gold2718
requested changes
Mar 6, 2025
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
I mostly have a suggestion and some questions but I wonder why useful comments need to be removed.
Include link to StandardNameRules.rst Co-authored-by: goldy <1588651+gold2718@users.noreply.github.com>
climbfuji
reviewed
Mar 14, 2025
| # end for | ||
| # end for | ||
| # end for | ||
|
|
Collaborator
There was a problem hiding this comment.
Please put that blank line back
mkavulich
added a commit
to mkavulich/ESMStandardNames
that referenced
this pull request
Mar 20, 2025
- start adding more units
Co-authored-by: Dom Heinzeller <dom.heinzeller@icloud.com>
gold2718
approved these changes
Mar 20, 2025
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This looks okay to me now, thanks for all the effort!
climbfuji
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.