Skip to content

Conversation

@jimmielin
Copy link
Member

Originator(s): @jimmielin

Most of the code based off from @fvitt; changes had to be made to remove use of pbuf and use the constituents infrastructure in CAM-SIMA/CCPP framework to register store prescribed aerosols data (code borrowed from @peverwhee and @nusbaume)

Companion SIMA PR ESCOMP/CAM-SIMA#441

There will not be a CAM PR to bring these changes back because tracer_data has breaking interface changes (and no longer using pbuf) that make it infeasible to bring back these schemes into CAM.

Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):

List all namelist files that were added or changed:

A       schemes/chemistry/prescribed_ozone_namelist.xml
A       schemes/chemistry/prescribed_aerosols_namelist.xml
A       schemes/chemistry/prescribed_aerosol_deposition_flux_namelist.xml

List all files eliminated and why: N/A

List all files added and what they do:

A       schemes/chemistry/prescribed_ozone.F90
A       schemes/chemistry/prescribed_ozone.meta
  - complete CCPPization of prescribed_ozone (#323)

A       schemes/chemistry/prescribed_aerosols.F90
A       schemes/chemistry/prescribed_aerosols.meta
  - complete CCPPization of prescribed_aero (#328)

A       schemes/chemistry/prescribed_aerosol_deposition_flux.F90
A       schemes/chemistry/prescribed_aerosol_deposition_flux.meta
  - CCPPize aerodep_flx for bulk aerosols (BAM) only. (#328) future work #329

A       test/test_suites/suite_tracer_data_test.xml
  - suite for testing tracer_data chemistry and aerosols input test via prescribed ozone, aerosols, and aerosol deposition flux -- BAM configuration

List all existing files that have been modified, and describe the changes:
(Helpful git command: git diff --name-status development...<your_branch_name>)
N/A

List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A

Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
new chemistry and aerosol schemes

If yes to the above question, describe how this code was validated with the new/modified features:
new regression test verified b4b with cam using same namelist options and input files as described in testmod - see CAM-SIMA PR

@jimmielin jimmielin self-assigned this Nov 12, 2025
@jimmielin jimmielin added enhancement New feature or request aerosols Is related to aerosols (including aerosol physics and chemistry). labels Nov 12, 2025
@jimmielin jimmielin requested a review from nusbaume December 3, 2025 19:48
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin for opening the first aerosol PR (of what I suspect will be many)! I have some questions and change requests, but hopefully nothing too difficult.

Of course if you do have any questions or concerns with any of my suggestions then just let me know. Thanks again!

@jimmielin jimmielin requested a review from nusbaume January 12, 2026 17:37
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing my suggestions @jimmielin! I had a couple other (very small) requests, but nothing that should hold up the PR.

real(kind_phys), intent(in) :: pint(:,:) ! air pressure at interfaces [Pa]
real(kind_phys), intent(in) :: phis(:) ! surface geopotential [m2 s-2]
real(kind_phys), intent(in) :: zi(:,:) ! height above surface, interfaces [m]
real(kind_phys), intent(out) :: prescribed_ozone(:,:) ! prescribed ozone mass mixing ratio [kg kg-1 dry]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jimmielin, I think that error is coming from the registry files's XML schema in CAM-SIMA.

It looks like the schema has already been updated to allow for upper-case characters, so I think all you need to do is update your branch to the head of CAM-SIMA and at least this error should be fixed. Of course if that doesn't work then please let me know!

integer :: aero_cnt ! # of aerosol constituents
integer :: aero_cnt_c ! # of cloud-borne species (for modal aerosols only)
integer :: aero_count ! # of aerosol constituents
integer :: aero_count_c ! # of cloud-borne species (for modal aerosols only)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick, but can we rename _c to something like _cld, to make it clearer as to what it actually means?

@nusbaume nusbaume requested a review from fvitt January 14, 2026 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aerosols Is related to aerosols (including aerosol physics and chemistry). enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants