-
Notifications
You must be signed in to change notification settings - Fork 32
Complete CCPPization of prescribed_ozone; prescribed_aero; aerodep_flx for bulk aerosols (BAM) #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Conversation
…ncy; misc updates
nusbaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jimmielin for opening the first aerosol PR (of what I suspect will be many)! I have some questions and change requests, but hopefully nothing too difficult.
Of course if you do have any questions or concerns with any of my suggestions then just let me know. Thanks again!
Co-authored-by: Jesse Nusbaumer <[email protected]>
Co-authored-by: Jesse Nusbaumer <[email protected]>
Co-authored-by: Jesse Nusbaumer <[email protected]>
nusbaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for implementing my suggestions @jimmielin! I had a couple other (very small) requests, but nothing that should hold up the PR.
| real(kind_phys), intent(in) :: pint(:,:) ! air pressure at interfaces [Pa] | ||
| real(kind_phys), intent(in) :: phis(:) ! surface geopotential [m2 s-2] | ||
| real(kind_phys), intent(in) :: zi(:,:) ! height above surface, interfaces [m] | ||
| real(kind_phys), intent(out) :: prescribed_ozone(:,:) ! prescribed ozone mass mixing ratio [kg kg-1 dry] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jimmielin, I think that error is coming from the registry files's XML schema in CAM-SIMA.
It looks like the schema has already been updated to allow for upper-case characters, so I think all you need to do is update your branch to the head of CAM-SIMA and at least this error should be fixed. Of course if that doesn't work then please let me know!
| integer :: aero_cnt ! # of aerosol constituents | ||
| integer :: aero_cnt_c ! # of cloud-borne species (for modal aerosols only) | ||
| integer :: aero_count ! # of aerosol constituents | ||
| integer :: aero_count_c ! # of cloud-borne species (for modal aerosols only) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit-pick, but can we rename _c to something like _cld, to make it clearer as to what it actually means?
Co-authored-by: Jesse Nusbaumer <[email protected]>
Originator(s): @jimmielin
Most of the code based off from @fvitt; changes had to be made to remove use of pbuf and use the constituents infrastructure in CAM-SIMA/CCPP framework to register store prescribed aerosols data (code borrowed from @peverwhee and @nusbaume)
Companion SIMA PR ESCOMP/CAM-SIMA#441
There will not be a CAM PR to bring these changes back because
tracer_datahas breaking interface changes (and no longer using pbuf) that make it infeasible to bring back these schemes into CAM.Description (include issue title and the keyword ['closes', 'fixes', 'resolves'] and issue number):
prescribed_ozone-- closes Convert prescribed_ozone to CCPP for testing tracer_data #323prescribed_aerointoprescribed_aerosolsscheme -- closes Convert prescribed_aero; aerodep_flx to CCPP #328aerodep_flxintoprescribed_aerosol_deposition_fluxscheme: only BAM functionality is fully implemented; MAM functionality depends on conversion of the aerosol model -- closes Convert prescribed_aero; aerodep_flx to CCPP #328; future work documented in Implement prescribed aerosol deposition fluxes (aerodep_flx) for MAM #329List all namelist files that were added or changed:
List all files eliminated and why: N/A
List all files added and what they do:
List all existing files that have been modified, and describe the changes:
(Helpful git command:
git diff --name-status development...<your_branch_name>)N/A
List all automated tests that failed, as well as an explanation for why they weren't fixed: N/A
Is this an answer-changing PR? If so, is it a new physics package, algorithm change, tuning change, etc?
new chemistry and aerosol schemes
If yes to the above question, describe how this code was validated with the new/modified features:
new regression test verified b4b with cam using same namelist options and input files as described in testmod - see CAM-SIMA PR