Skip to content

Conversation

@nmizukami
Copy link
Collaborator

@nmizukami nmizukami commented Dec 24, 2025

A few fixes related to cesm coupling:

  1. Previously the coupling frequency was allowed to be more than 1 day because coupling_period was integer and unit of the coupling frequency was set to day in nuopc. Here, the type of coupling_period was changed to real and unit of frequency is set to sec. This allows us to use sub-daily coupling frequency and also make the code slightly cleaner (removed some lines)

  2. Also there was bug (wrong loop index variable) when checking the outlet reach, which is fixed here. This fix seems to enable mizuRoute to run in fully CESM coupled mode without crash.

Fix #594

@nmizukami nmizukami requested a review from ekluzek December 24, 2025 15:46
@nmizukami nmizukami added cesm-coupling For cesm coupling cleanup clean up the codes (remove unnecessary lines, indentation, styles) bugfix labels Dec 24, 2025
Copy link
Collaborator

@ekluzek ekluzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We worked on this together, and it makes sense as to what needs to be done.

Mostly fine detail and nothing needed to change or add documentation or notes on.

@nmizukami nmizukami merged commit 75b7e3a into ESCOMP:main Jan 15, 2026
1 check passed
@nmizukami nmizukami deleted the cpl_fixes branch January 15, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix cesm-coupling For cesm coupling cleanup clean up the codes (remove unnecessary lines, indentation, styles)

Development

Successfully merging this pull request may close these issues.

mizuRoute NUOPC cap only allows running with a daily or more coupling period

2 participants