-
Notifications
You must be signed in to change notification settings - Fork 43
Documentation layout to highlight 2 packages #2732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2732 +/- ##
=======================================
Coverage 95.46% 95.46%
=======================================
Files 260 260
Lines 15519 15519
=======================================
Hits 14815 14815
Misses 704 704 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Currently just has ESMValCore for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The docs build fine. Landing page, header and sidebars are similar to the PR in the tool. The only difference I noticed were the icons in the header:
Both versions are fine (I personally prefer the simple icons as they are here), but would be nice to have them consistent.
@flicj191 if you are ok with me committing the other minor comments, I can do so and this can be merged.
Description
For parallel updates to ESMValTool documentation:
ESMValGroup/ESMValTool#3914
Closes issue: ESMValGroup/ESMValTool#3860
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: