-
Couldn't load subscription status.
- Fork 43
Move concatenate preprocessor function to its own module #2766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2766 +/- ##
=======================================
Coverage 95.30% 95.31%
=======================================
Files 259 260 +1
Lines 15350 15357 +7
=======================================
+ Hits 14629 14637 +8
+ Misses 721 720 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Bouwe, looks good! Do you want to fix the 3 remaining Codacy issues? Looks pretty straightforward.
|
(Codecov shows that 1 line is missing tests, but after clicking on it I don't see anything...so I guess this is fine) |
it's complaining it can't find Head report, for some reason https://app.codecov.io/gh/ESMValGroup/ESMValCore/pull/2766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ESMValGroup - lemme merge |
|
cheers bud, what Manu says (also about the Codacy complaints) 🍺 I can merge at the end, when all is ready 👍 |
|
Perfect, now it shows the missing line. Would it be possible to add a test for that? Should be very simple, thanks! |
|
Thanks for taking a look @schlunma and @valeriupredoi. I fixed one more Codacy issue and added a test for the one line that was not covered. I'm not sure how to solve the two remaining Codacy issues though. You're welcome to have a go at it if you have ideas. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
spiffy! 🍺
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🚀
Description
Having the
concatenatepreprocessor function in theesmvalcore.preprocessor._iomodule is causing circular import issues in #2765. To keep changes to a minimum in that pull request, I created a separate pull request just to move it.Closes #issue_number
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: