Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Jul 3, 2025

Description

Having the concatenate preprocessor function in the esmvalcore.preprocessor._io module is causing circular import issues in #2765. To keep changes to a minimum in that pull request, I created a separate pull request just to move it.

Closes #issue_number

Link to documentation:


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number pull requests:

@bouweandela bouweandela added the preprocessor Related to the preprocessor label Jul 3, 2025
@codecov
Copy link

codecov bot commented Jul 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.31%. Comparing base (4d8fcbf) to head (5c8e475).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2766   +/-   ##
=======================================
  Coverage   95.30%   95.31%           
=======================================
  Files         259      260    +1     
  Lines       15350    15357    +7     
=======================================
+ Hits        14629    14637    +8     
+ Misses        721      720    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bouweandela bouweandela marked this pull request as ready for review July 4, 2025 06:32
@schlunma schlunma added this to the v2.13.0 milestone Jul 4, 2025
Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Bouwe, looks good! Do you want to fix the 3 remaining Codacy issues? Looks pretty straightforward.

@schlunma
Copy link
Contributor

schlunma commented Jul 4, 2025

(Codecov shows that 1 line is missing tests, but after clicking on it I don't see anything...so I guess this is fine)

@valeriupredoi
Copy link
Contributor

(Codecov shows that 1 line is missing tests, but after clicking on it I don't see anything...so I guess this is fine)

it's complaining it can't find Head report, for some reason https://app.codecov.io/gh/ESMValGroup/ESMValCore/pull/2766?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=ESMValGroup - lemme merge main and see if it fixes itself

@valeriupredoi
Copy link
Contributor

cheers bud, what Manu says (also about the Codacy complaints) 🍺 I can merge at the end, when all is ready 👍

@schlunma
Copy link
Contributor

schlunma commented Jul 4, 2025

Perfect, now it shows the missing line. Would it be possible to add a test for that? Should be very simple, thanks!

@bouweandela
Copy link
Member Author

Thanks for taking a look @schlunma and @valeriupredoi. I fixed one more Codacy issue and added a test for the one line that was not covered. I'm not sure how to solve the two remaining Codacy issues though. You're welcome to have a go at it if you have ideas.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spiffy! 🍺

Copy link
Contributor

@schlunma schlunma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🚀

@schlunma schlunma merged commit a315198 into main Jul 4, 2025
7 checks passed
@schlunma schlunma deleted the create-concatenate-module branch July 4, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preprocessor Related to the preprocessor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants