Record attributes in provenance via the LocalFile interface instead of directly accessing the file

[bouweandela]

Description

Record attributes in provenance via the interface provided by esmvalcore.local.LocalFile instead of directly accessing the file from the provenance module. This is needed to facilitate loading other data than NetCDF files while still maintaining informative provenance records.

This is a first step towards supporting different data sources in #2765.

---

Before you get started

• ☝ Create an issue to discuss what you are going to do

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

• 🧪 The new functionality is relevant and scientifically sound
• 🛠 This pull request has a descriptive title and labels
• 🛠 Code is written according to the code quality guidelines
• 🧪 and 🛠 Documentation is available
• 🛠 Unit tests have been added
• 🛠 Changes are backward compatible
• 🛠 The list of authors is up to date
• 🛠 All checks below this pull request were successful

---

To help with the number pull requests:

• 🙏 We kindly ask you to review two other open pull requests in this repository

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.46%. Comparing base (4b3e8b0) to head (104efd7).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2854      +/-   ##
==========================================
- Coverage   95.46%   95.46%   -0.01%     
==========================================
  Files         260      260              
  Lines       15526    15519       -7     
==========================================
- Hits        14822    14815       -7     
  Misses        704      704              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[valeriupredoi]

looks good and useful indeed! Things may get hairy when we access eg Zarr attributes etc, but we'll bridge that bridge when we get there; just one (dumb) question about having to reload the data in local.py buds 🍺

[valeriupredoi]

where does this sit inside the stack - as in, can we not pass already loaded cube(lists) sitting in memory, do we have to load separately? It's just that iris I/O is costly

[bouweandela]

The preprocessor function load calls this method instead of acessing the files itself. That makes it possible to introduce more classes like LocalFile for different data sources in #2765 without further modifications of the existing code.

[valeriupredoi]

Ok - am not 100% sold on that but let's see the final structure when we use it via #2765 - definitely not the place to complain here 😃

[valeriupredoi]

you should leave your introspective comments and not obsolete them out - those were interesting notes!

[bouweandela]

Thanks for reviewing @valeriupredoi!