-
Notifications
You must be signed in to change notification settings - Fork 44
Sort __all__ in Python modules
#2914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The tests are failing because the server with zarr files used for testing is not available. @valeriupredoi Any idea what's going on there? Could we make the tests more robust to an offline server? |
temporarily unavailable - https://uor-aces-o.s3-ext.jc.rl.ac.uk/esmvaltool-zarr/pr_Amon_CNRM-ESM2-1_02Kpd-11_r1i1p2f2_gr_200601-220112.zarr3/zarr.json works well now - we could make them server-proof, but that resource is pretty much like an ESGF node, very rarely goes offline, problem is that, unlike an ESGF node that can be replaced with another node, that's the only resource |
|
WTH is going on with the blithering bucket? Hang on, I spoke too soon 🤦♂️ EDIT: clear issue with the S3 object store at CEDA, so I pinged them: |
It would be great if you could have a go, this isn't the first time tests are failing because it's offline. |
shall do! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2914 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 266 266
Lines 15520 15520
=======================================
Hits 14834 14834
Misses 686 686 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
should be fixed now, I got in touch with CEDA. The thing about that S3 bucket is, we could pop a |
|
I agree that it's a good idea to set up testing for that storage service if the people operating it do not monitor it, but those should be separate tests outside of the ESMValCore repository, because now it is hampering our development. |
Description
Fix a formatting issue introduced in #2911.
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: