-
Notifications
You must be signed in to change notification settings - Fork 44
Move preprocessor output filename template to new configuration #2923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f01c6d1 to
6770eee
Compare
6770eee to
fd5992d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2923 +/- ##
==========================================
+ Coverage 95.57% 95.59% +0.01%
==========================================
Files 266 266
Lines 15520 15556 +36
==========================================
+ Hits 14834 14870 +36
Misses 686 686 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
valeriupredoi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks very good - I am wondering if we want to start thinking about allowing preprocessor files that are not netCDF4 for regular cases ie allow a bit of flexibility when it comes to appending that .nc extension - probably, but in the future, and definitely outside the scope of this PR. Cheers @bouweandela 🍻
|
I considered the option of adding a |
Description
Move the preprocessor output filename template to the new configuration.
Upgrade instructions
If you have defined projects in config-developer.yml that are not in the default config-developer.yml file shipped with ESMValCore, then you will need to move the value of 'output_file' to
Closes #2919
Link to documentation:
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: