Skip to content

Conversation

@bouweandela
Copy link
Member

@bouweandela bouweandela commented Sep 4, 2025

Description

Use pip install --no-deps to avoid overwiting packages from the conda environment


Before you get started

Checklist

It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.


To help with the number of pull requests:

@bouweandela
Copy link
Member Author

Tests are failing pip check with the message:

esmvalcore 2.13.0rc1 requires intake-esm, which is not installed.
dodgy 0.2.1 is not supported on this platform
pylint-flask 0.6 is not supported on this platform

@jlenh It looks like you may have forgotten to add intake-esm as a dependency on conda-forge for the ESMValCore v2.13.0rc1 release candidate

The other two packages are related to prospector/pylint, so I will try to solve #3739 before continuing with this pull request.

@jlenh
Copy link
Contributor

jlenh commented Sep 12, 2025

Tests are failing pip check with the message:

esmvalcore 2.13.0rc1 requires intake-esm, which is not installed.
dodgy 0.2.1 is not supported on this platform
pylint-flask 0.6 is not supported on this platform

@jlenh It looks like you may have forgotten to add intake-esm as a dependency on conda-forge for the ESMValCore v2.13.0rc1 release candidate

The other two packages are related to prospector/pylint, so I will try to solve #3739 before continuing with this pull request.

I am preparing esmvalcore 2.13.0rc3, I will include it then if that's alright?

@bouweandela
Copy link
Member Author

Yes, that would be great.

Copy link
Contributor

@valeriupredoi valeriupredoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many thanks @jlenh - would you have a bit of time to pop the same flags in the GHAs? No worries, I can do that if it's too much hassle 🍺

@jlenh
Copy link
Contributor

jlenh commented Sep 12, 2025

many thanks @jlenh - would you have a bit of time to pop the same flags in the GHAs? No worries, I can do that if it's too much hassle 🍺

Do you mean in these places? (to make sure I do not miss any)

run: pip install -e .[develop]

- run: pip install -e .[develop]

run: pip install -e .[develop] 2>&1 | tee source_install_linux_artifacts_python_${{ matrix.python-version }}/install.txt

run: pip install -e .[develop] 2>&1 | tee test_linux_artifacts_python_${{ matrix.python-version }}/install.txt

pip install -e .[develop] 2>&1

run: pip install -e .[develop] 2>&1 | tee develop_test_linux_artifacts_python_${{ matrix.python-version }}/install.txt

pip install -e .[develop]

run: pip install -e .[develop] 2>&1 | tee test_linux_artifacts_python_${{ matrix.python-version }}/install.txt

run: pip install -e .[develop] 2>&1 | tee test_osx_artifacts_python_${{ matrix.python-version }}/install.txt

@valeriupredoi
Copy link
Contributor

@jlenh yessir, those there indeed 🍺

@valeriupredoi valeriupredoi mentioned this pull request Sep 15, 2025
5 tasks
@valeriupredoi
Copy link
Contributor

@jlenh @bouweandela this should be good to run on green too, now that Julien released rc4 (well, in a couple hous when conda forge records get updated)

@valeriupredoi
Copy link
Contributor

@bouweandela I've merged and fixed the latest main into this - it looks like pip check is hitting the same issue as prospector hits at build on the feedstock, might not want to use pip check while we still pull in prospector 🍺

@valeriupredoi
Copy link
Contributor

@bouweandela let's remove pip check and merge this now, I think it's better if we merged now and not waited for the complete removal of prospector

@bouweandela
Copy link
Member Author

That would lead to us having a development environment with incompatible versions of software installed. Why the rush? This issue has been open for years

@valeriupredoi
Copy link
Contributor

That would lead to us having a development environment with incompatible versions of software installed. Why the rush? This issue has been open for years

@jlenh will have to close one eye at the failed Monitor Test GHA when releasing, but OK - we'll make sure he don't complain 😁 The env is not broken per se, it's just missing a couple prospector components that we don't even need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use the --nodeps option when installing from PyPI?

4 participants