-
Couldn't load subscription status.
- Fork 142
Fix JRA-55 downloader #4191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix JRA-55 downloader #4191
Conversation
|
I think there might be changes coming as they are migrating their website today (cf. https://rda.ucar.edu/news/rda-gdex-relaunch/). I will have a look tomorrow! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Lisa, the new link works perfectly!
I think there are few things to remove still from the old code that are not relevant anymore:
- Removing the temporary files is not needed anymore
ESMValTool/esmvaltool/cmorizers/data/downloaders/datasets/jra_55.py
Lines 123 to 126 in c31a664
if os.path.exists("Authentication.log"): os.remove("Authentication.log") if os.path.exists("auth.rda_ucar_edu"): os.remove("auth.rda_ucar_edu") - The use of the
download_optionsparameter is not needed anymore
ESMValTool/esmvaltool/cmorizers/data/downloaders/datasets/jra_55.py
Lines 110 to 112 in c31a664
downloader.download_file( url + f"/{channel}/{year}/" + fname, download_options )
|
@jlenh I still have problems with the downloaded data, as the formatter is not working with them. The files are too small. Did you experience the same issue? |
The formatter raises |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
many thanks Lisa 🍻 Ah just noticed the network comms issues - Julien is on it, I see
Description
The downloading works now without RDA login. And the link to the data changed.
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
New or updated data reformatting script