Refactor _getEtag to get etag from gzip instead of buffer #270
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the _getEtag implementation in AsyncWebServerRequest to improve how ETags are generated.
Previously, the method relied on a 4-byte trailer buffer passed as a parameter. This has been replaced with a more robust approach: the function now reads the CRC directly from the last 8 bytes of the gzip file. This ensures that the ETag is derived from the actual file contents rather than depending on an external buffer.
Key changes:
_getEtag now accepts a File handle instead of a trailer array.
The method seeks to the gzip footer (size - 8) and extracts the CRC.
Returns bool to indicate success/failure.
ETag generation logic remains the same, ensuring backward compatibility for clients relying on ETags.
This change improves correctness, reduces external dependencies, and makes ETag generation more consistent with the gzip specification.