Skip to content

fix(sse): break loop after erasing client #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vortigont merged 1 commit into from
Jan 28, 2025
Merged

fix(sse): break loop after erasing client #29

vortigont merged 1 commit into from
Jan 28, 2025

Conversation

@mathieucarbou
Copy link
Member

@mathieucarbou mathieucarbou commented Jan 28, 2025

@mathieucarbou mathieucarbou requested a review from a team January 28, 2025 19:29
@mathieucarbou mathieucarbou self-assigned this Jan 28, 2025
vortigont
vortigont approved these changes Jan 28, 2025
View reviewed changes
Copy link

@vortigont vortigont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Nice catch indeed!

@vortigont vortigont merged commit 7be1742 into main Jan 28, 2025
22 checks passed
@mathieucarbou
Copy link
Member Author

mathieucarbou commented Jan 28, 2025

Ah! Nice catch indeed!

I found another one similar in WS code... Will open a PR...

@mathieucarbou mathieucarbou deleted the issues/28 branch January 28, 2025 20:00
@mathieucarbou mathieucarbou mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vortigont vortigont vortigont approved these changes

Assignees

@mathieucarbou mathieucarbou

Labels

Status: Pending Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Crash after client disconnect from Server-Sent-Events

3 participants

@mathieucarbou @vortigont