Skip to content

Continue on cert errors #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
painter1 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Continue on cert errors #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4afa653
Allow Synda to continue after an exception getting a certificate.
painter1 Mar 2, 2021
af79b8b
Use the correct function name to provide access to continue_on_cert_e…
painter1 Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion synda/sdt/sddmdefault.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,14 @@ def transfers_begin(transfers):
"Exception occured while retrieving certificate ({})".format(e),
)

raise
sdlog.error("SDDMDEFA-503"," continue_on_cert_errors=%s"%
preferences.is_download_continue_on_cert_errors )
if preferences.is_download_continue_on_cert_errors:
sdlog.error("SDDMDEFA-504","Ignoring exception")
pass # Try to keep on going, probably a certificate isn't needed.
else:
sdlog.error("SDDMDEFA-505","Re-raising exception")
raise

for tr in transfers:
start_transfer_thread(tr)
Expand Down
2 changes: 1 addition & 1 deletion synda/source/config/file/user/preferences/dao/create/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ def __init__(self, full_filename):
config.set('download', 'http_fallback', 'false')
config.set('download', 'gridftp_opt', '')
# config.set('download', 'incremental_mode_for_datasets', 'false')
# config.set('download', 'continue_on_cert_errors', 'false')
config.set('download', 'continue_on_cert_errors', 'false')
config.set('download', 'url_max_buffer_size', '3500')

# nouvelles variables
Expand Down
4 changes: 4 additions & 0 deletions synda/source/config/file/user/preferences/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,10 @@ def download_max_parallel_download_per_datanode(self):
def download_url_max_buffer_size(self):
return self.get_data().getint('download', 'url_max_buffer_size')

@property
def is_download_continue_on_cert_errors(self):
return self.get_data().getboolean('download', 'continue_on_cert_errors')

@property
def download_gridftp_opt(self):
return self.get_data().get('download', 'gridftp_opt')
Expand Down