-
Notifications
You must be signed in to change notification settings - Fork 7
Fix CI #150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix CI #150
Changes from 2 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
dcd5cf7
Pin typing-extensions in Python 3.6
885ea41
Pin importlib_resources
9efb3b7
Fix python version handling in CI
ac60de1
Add missing phantomjs to test dependencies
f7245c9
Remove pinning of pyqt 5.12
923ba51
Ensure phantomjs is available in PATH before starting tests
f83f611
WIP test only in py36
89e3c6e
List conda environment after creation
36e3a91
Revamp timeout handling in _wait_graph_page_ready
f20a6f2
Remove install Qt step
4adffc4
Use Firefox as webdriver for tests
8d8175e
Debug Firefox error
d15922e
Change 'callback' to 'window.callback' per Prusse's suggestion
d841d7f
Use `window.callback` when creating the callbacks
prusse-martin 556327b
Update error msg expected values
prusse-martin cf9f3c6
Update expected test coordinates
8aebe07
Fix test_set_popup_menu_handler to handle async results
eb27046
Remove -x from test command
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we always default
PYTHON_VERSIONto "3.6" given we never explicitly set it.