Skip to content

transform functions and extras in helpers#130

Merged
KrisThielemans merged 6 commits intoETSInitiative:mainfrom
KrisThielemans:geom_helpers
Jun 25, 2025
Merged

transform functions and extras in helpers#130
KrisThielemans merged 6 commits intoETSInitiative:mainfrom
KrisThielemans:geom_helpers

Conversation

@KrisThielemans
Copy link
Contributor

@KrisThielemans KrisThielemans commented Jun 22, 2025

Changes in this pull request

  • moved transform functions from plot_scanner to helpers.geometry (Python) petsird_helpers::geometry (C++)
  • add equivalent C++ functions
  • add get_detecting_box helpers to find the BoxShape for an ExpandedDetectionBin
  • C++: add petsird_helpers/create.h to make it easier to create new ScannerInformation objects

Related issues

#127

[x] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in the ETSI software (the Work) under the terms and conditions of the Apache-2.0 License.

@KrisThielemans KrisThielemans added this to the v0.7 milestone Jun 22, 2025
@KrisThielemans KrisThielemans self-assigned this Jun 22, 2025
@KrisThielemans KrisThielemans linked an issue Jun 23, 2025 that may be closed by this pull request
WARNING: needs xtensor--blas at the moment

I've removed xtensor-fft though, as this was an MRI copy-paste
presumably.
This hopefully avoids confusing users too much, as well as
isolating them from the exact type definitions of the nested vectors
depending on type_of_module.
follow yardl's "configurable array" API
@KrisThielemans KrisThielemans merged commit 8029ee4 into ETSInitiative:main Jun 25, 2025
2 checks passed
@KrisThielemans KrisThielemans deleted the geom_helpers branch June 25, 2025 17:07
@KrisThielemans KrisThielemans changed the title transform functions in helpers transform functions and extras in helpers Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

create helpers for geometric calculations

1 participant