Skip to content

fix get_detection_efficiency python helper #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KrisThielemans merged 1 commit into from
Jul 16, 2025
Merged

fix get_detection_efficiency python helper #146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions python/petsird/helpers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,16 +87,19 @@ def get_detection_efficiency(scanner: petsird.ScannerInformation,
type_of_module_pair: petsird.TypeOfModulePair,
event: petsird.CoincidenceEvent) -> float:
"""Compute the detection efficiency for a coincidence event"""
eff = 1
if scanner.detection_efficiencies is None:
# should never happen really, but this way, we don't crash.
return 1.

eff = 1.

# per detection_bin efficiencies
if scanner.detection_efficiencies is not None:
detection_bin_efficiencies = scanner.detection_efficiencies.detection_bin_efficiencies
if detection_bin_efficiencies is not None:
detection_bin_efficiencies0 = (
scanner.detection_efficiencies.detection_bin_efficiencies[
type_of_module_pair[0]])
detection_bin_efficiencies[type_of_module_pair[0]])
detection_bin_efficiencies1 = (
scanner.detection_efficiencies.detection_bin_efficiencies[
type_of_module_pair[1]])
detection_bin_efficiencies[type_of_module_pair[1]])
eff *= (detection_bin_efficiencies0[event.detection_bins[0]] *
detection_bin_efficiencies1[event.detection_bins[1]])
if eff == 0:
Expand Down
Loading