Skip to content

Change base_url handling in API#224

Merged
lukas-phaf merged 2 commits intomainfrom
base-url
May 20, 2025
Merged

Change base_url handling in API#224
lukas-phaf merged 2 commits intomainfrom
base-url

Conversation

@lukas-phaf
Copy link
Contributor

@lukas-phaf lukas-phaf commented Feb 14, 2025

Remove code with misleading comments which does not achieve anything.

This should be double-checked on the test system to make sure it works with the proxy configuration.

@lukas-phaf lukas-phaf changed the title Remove code with misleading comments which does not achieve anything. Change base_url handling in API Feb 14, 2025
@github-actions
Copy link

github-actions bot commented Feb 14, 2025

Coverage

Unit Test Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
datastore_pb2.py614821%34–81
datastore_pb2_grpc.py542750%15–16, 19, 65–80, 121–123, 128–130, 135–137, 142–144, 148–173, 219, 246, 273, 300
export_metrics.py100100% 
grpc_getter.py201145%15–24, 28–31, 35–37, 41–43
main.py45784%51, 56, 66, 76–77, 87–88
metadata_endpoints.py693254%50–59, 63, 115, 130–257, 261
response_classes.py50100% 
utilities.py1773680%21, 39, 46, 68–71, 79–90, 95, 115, 119, 121, 149, 155, 173, 231–237, 241–243, 273, 277, 299, 304
custom_geo_json
   edr_feature_collection.py60100% 
formatters
   __init__.py110100% 
   covjson.py60198%91
   geojson.py21290%27, 52
openapi
   custom_dimension_examples.py40100% 
   edr_query_parameter_descriptions.py110100% 
   openapi_examples.py130100% 
   openapi_metadata.py10100% 
routers
   __init__.py00100% 
   edr.py101496%348–349, 438–439
   feature.py471960%99–132, 148–153, 159–181
TOTAL71618774% 

Title Coverage Tests Skipped Failures Errors Time
API Unit Tests Coverage 40 0 💤 0 ❌ 0 🔥 1.957s ⏱️
Ingest Unit Tests Coverage 16 0 💤 0 ❌ 0 🔥 11.805s ⏱️

@lukas-phaf lukas-phaf marked this pull request as ready for review February 14, 2025 15:42
Copy link
Collaborator

@Teddy-1000 Teddy-1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed correct behind proxy.

@lukas-phaf lukas-phaf merged commit 2444033 into main May 20, 2025
8 checks passed
@lukas-phaf lukas-phaf deleted the base-url branch May 20, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants