Skip to content

RSFC fix#31

Merged
tamasgal merged 2 commits intomainfrom
rsfc-fix
Feb 2, 2026
Merged

RSFC fix#31
tamasgal merged 2 commits intomainfrom
rsfc-fix

Conversation

@tamasgal
Copy link
Member

@tamasgal tamasgal commented Feb 2, 2026

Fixes the way the reports are handled in the RSFC plugin.

@tamasgal
Copy link
Member Author

tamasgal commented Feb 2, 2026

Sorry for the noise but I also removed a lot of trailing whitespace

@tamasgal
Copy link
Member Author

tamasgal commented Feb 2, 2026

@andriumon this is a hotfix for the currently not-working RSFC plugin. One of the key issues is that the plugin checks for exactly one file (although another JSON file is produced) and picks the first one, which is not the "assessment" file it expects.

I think that the rsfc plugin has been evolved and we are lacking some downstream changes with respect to #21

Currently I am also using a custom Docker image of rsfc because of oeg-upm/rsfc#67 and oeg-upm/rsfc#66

@tamasgal tamasgal merged commit e6d0547 into main Feb 2, 2026
0 of 11 checks passed
@dgarijo
Copy link

dgarijo commented Feb 2, 2026

@andriumon please have a look at this.
At the moment if things are working for the GAM, I would not do further changes. Please prepare another release so we can use resqui afte the GAM

@tamasgal
Copy link
Member Author

tamasgal commented Feb 2, 2026

The rsfc-based plugins do not work currently, see both issues mentioned above.

@tamasgal
Copy link
Member Author

tamasgal commented Feb 2, 2026

I mean, with this PR they work 😉

@andriumon
Copy link
Contributor

Ok, will look into it. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants