Add PaNOSC Research Software Stories - alpaka and PiConGPU#584
Add PaNOSC Research Software Stories - alpaka and PiConGPU#584srghosh56 wants to merge 51 commits intoEVERSE-ResearchSoftware:mainfrom
Conversation
✅ Deploy Preview for everse-rsqkit-testing ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi Srobona, Thank you for this! There's quite a few issues here, some minor, some larger. I've captured them below. Needs addressing:
Ought to be addressed:
Would be nice to address:
Key Rationale:
Pragmatically, take a look a this, and decide what you agree needs addressing, then please make changes, push to your branch to update the PR and then we can follow up. We can then decide what to merge! Many thanks for this! Michael. |
sparkslabs
left a comment
There was a problem hiding this comment.
Larger comment on changes included in the discussion - which collates everything.
Generally this is a great addition - the requested changes are largely for consistency and integration :-) (but the "Needs to be addressed" really do need to be :) )
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/picongpu_research_software_story.md
Outdated
Show resolved
Hide resolved
pages/research_software_stories/alpaka_research_software_story.md
Outdated
Show resolved
Hide resolved
|
Summarised comments here -- #584 (comment) |
|
@srghosh56 can you take a first shot at addressing all these valuable comments and tell me where you need input from me or the alpaka/PIConGPU maintainers? |
|
Hello, @sparkslabs , thank you so much for the comments. I have addressed almost all of them. Can you please take a relook at them? Hello, @juckel , do the maintainers want to be added as contributors? |
|
Hi @srghosh56 I'll take a look. On the note of contributors, the contributors who get added to a research software story page are those people who have directly contributed to the story - text, sanity/correctness checking etc, |
Fixes #355 & #356
Adds two PaNOSC Research Software Stories - alpaka and PiConGPU