Merged
Conversation
fdiblen
reviewed
Dec 8, 2025
fdiblen
reviewed
Dec 8, 2025
fdiblen
reviewed
Dec 8, 2025
fdiblen
requested changes
Dec 8, 2025
Contributor
fdiblen
left a comment
There was a problem hiding this comment.
Thank you for the PR, @shraddha-bajare. I suggested removing two unrelated indicators.
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
Co-authored-by: fdiblen <144492+fdiblen@users.noreply.github.com>
vuillaut
approved these changes
Jan 7, 2026
vuillaut
requested changes
Jan 7, 2026
Contributor
vuillaut
left a comment
There was a problem hiding this comment.
https://w3id.org/everse/i/indicators/no_leaked_credentials
should actually go in measures... - gitleaks only "measures" if there are leaked credentials but does not remove them or fix the leak.
Collaborator
Author
made the updates |
fdiblen
requested changes
Jan 22, 2026
Contributor
There was a problem hiding this comment.
Hi @shraddha-bajare,
Thank you for updating the PR. I suggest we remove version_control_use. After that feel free to merge!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #177