Draft
Conversation
martinlukas84
requested review from
Pietfried,
SebaLukas,
a-w50,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
florinmihut,
hikinggrass,
james-ctc and
mlitre
as code owners
… other modules like API etc. This is helpful for process view. Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
…p this to string and publish the code via interface. Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
martinlukas84
force-pushed
the
feature/ev_response_code
branch
from
a53b483 to
d86bd15
Compare
mhei
reviewed
Jan 21, 2026
SebaLukas
requested changes
Jan 22, 2026
| call_if_available(callbacks.ev_termination, ev_termination_code, ev_termination_explanation); | ||
| } | ||
|
|
||
| void Feedback::response_code(const iso15118::message_20::datatypes::ResponseCode& code) const { |
Member
There was a problem hiding this comment.
Unit test(s) for response_code is/are missing
| const auto res = handle_request(*req, m_ctx.session, false); | ||
|
|
||
| m_ctx.respond(res); | ||
| m_ctx.feedback.response_code(res.response_code); |
Member
There was a problem hiding this comment.
Maybe it would be possible to call feedback.responce_code() not in every state. Maybe it is possible to call that function in the context respond function or in the Session::poll function
interface/iso15118_charger: change the ResponseCode entry to rely on iso15118 type Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
…ic types Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
SebaLukas
reviewed
Jan 27, 2026
…118_charger.yaml file Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
SebaLukas
reviewed
Jan 28, 2026
types/iso15118.yaml
Outdated
| ev_termination_explanation: | ||
| description: Contains the EV termination explanation | ||
| type: string | ||
| type: string No newline at end of file |
Member
|
What is the status of this PR? There are still some unresolved issues. |
Contributor
Author
|
Still in progress due lack of time. |
Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
Signed-off-by: Martin Lukas <martin.lukas@chargebyte.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR publishes the response code via interface in Everest environment.
This is useful for process view or usage in other modules like API etc.
Issue ticket number and link
Checklist before requesting a review