Skip to content

framework: replace mqtt-c with mosquitto#1799

Draft
hikinggrass wants to merge 6 commits intomainfrom
feature/framework-replace-mqtt-c-with-mosquitto
Draft

framework: replace mqtt-c with mosquitto#1799
hikinggrass wants to merge 6 commits intomainfrom
feature/framework-replace-mqtt-c-with-mosquitto

Conversation

@hikinggrass
Copy link
Member

Describe your changes

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

}
// Create event handler and register clients
everest::lib::io::event::fd_event_handler ev_handler;
ev_handler.register_event_handler(&*this->mqtt_client);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that just
mqtt_client.get()

topic,
[this](everest::lib::io::mqtt::mosquitto_cpp& client,
everest::lib::io::mqtt::mosquitto_cpp::message const& message) {
this->message_queue.add(std::unique_ptr<Message>(new Message{message.topic, message.payload}));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest std::make_unique

Use the mosquitto based everest::io::mqtt in the framework MQTT abstraction code

Make everest::io position independent

Use mosquitto_connect_async when no bind_address is used in mosquitto_cpp wrapper

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Use topic available at subscribe time instead of receive time to better handle wildcards

Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass force-pushed the feature/framework-replace-mqtt-c-with-mosquitto branch from 4946199 to e41c316 Compare February 23, 2026 08:40
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
@hikinggrass hikinggrass force-pushed the feature/framework-replace-mqtt-c-with-mosquitto branch from acfb239 to 94b5bb8 Compare February 23, 2026 13:12
@dorezyuk
Copy link
Contributor

dorezyuk commented Mar 2, 2026

I think you will need this bazelbuild/bazel-central-registry#7746 to make it work with bazel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants