Open
Conversation
…he everst_api_types lib Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de> Fix AsyncAPI definition for entrypoint_API Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
Signed-off-by: Christoph Burandt <christoph.burandt@pionix.de>
cburandt
requested review from
Pietfried,
SebaLukas,
andistorm,
corneliusclaussen,
djchhp,
florinmihut,
hikinggrass,
james-ctc and
mlitre
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Improves the error message during autogenerating tests for the EVerest_API-types.
Adding a new type to the EVerestAPI requires changing of/creating a new lib/everest/everest_api_types/include/.../API.hpp.
Unit-test for (de-)serialization of these tests are auto-generated during the build.
Auto-generation fails for unsupported base-types. The resulting error-message did not point to the actual problem.
The change allows the auto-generator to name the data-structure that caused the problem and clearly states which type cannot be used (e.g. use of an int instead of int32_t).
Issue ticket number and link
Checklist before requesting a review