Skip to content

Fix cable check race condition causing permanent charger inoperability (#1392) #1900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rishabhvaish wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix cable check race condition causing permanent charger inoperability (#1392) #1900

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5bf6514
Fix race condition in fail_cable_check causing permanent charger inop…
rishabhvaish Mar 1, 2026
71707f2
fix(evse): fold Idle/Finished check into existing raise_cable_check_f…
rishabhvaish Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions modules/EVSE/EvseManager/EvseManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2535,6 +2535,16 @@ void EvseManager::fail_cable_check(const std::string& reason) {
}
r_hlc[0]->call_cable_check_finished(false);
}
// Do not raise a cable check fault if the car has already been unplugged.
// This prevents a race condition where the detached cable check thread raises an error
// after clear_errors_on_unplug() has already run, leaving the charger permanently
// inoperative (see GitHub issue #1392).
const auto current_state = charger->get_current_state();
if (current_state == Charger::EvseState::Idle || current_state == Charger::EvseState::Finished) {
EVLOG_info << "Cable check failed due to: " << reason
<< ", but session already ended (car unplugged). Not raising cable check fault error.";
return;
}

// Raising a cable check fault should not happen if a cancel_transaction (DeAuthorized) is triggered
// during cable check
Expand Down