Draft: libiso15118: d2: State ServiceDiscovery (#1840)#1919
Open
Dalachowsky wants to merge 1 commit intoEVerest:feat/adding-iso2-supportfrom
Open
Conversation
Did a general draft of the ServiceDiscovery state. Moved datatypes to msg_data_types.hpp. Also noticed that there was a duplicate EnergyTransferMode definition inside ServiceDiscovery and ChargeParameterDiscovery. Signed-off-by: Kacper Dalach <kdalach@elektrometal.com.pl>
Dalachowsky
requested review from
Pietfried,
SebaLukas,
andistorm,
cburandt,
corneliusclaussen,
djchhp,
florinmihut,
hikinggrass,
james-ctc and
mlitre
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Did a general draft of the ServiceDiscovery state.
Moved datatypes to msg_data_types.hpp.
Also noticed that there was a duplicate EnergyTransferMode
definition inside ServiceDiscovery and ChargeParameterDiscovery.
Issue ticket number and link
#1840
Checklist before requesting a review