This repository was archived by the owner on Dec 9, 2025. It is now read-only.
Merged
Conversation
Member
hikinggrass
commented
Jan 7, 2025
hikinggrass
commented
- More const ref usage
- fix narrowing and widening conversion warnings
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
…imum length Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
a-w50
suggested changes
Jan 7, 2025
lib/everest.cpp
Outdated
| if (this->module_manifest.contains("enable_global_errors") && | ||
| this->module_manifest.at("enable_global_errors").get<bool>()) { | ||
| std::shared_ptr<error::ErrorDatabaseMap> global_error_database = std::make_shared<error::ErrorDatabaseMap>(); | ||
| const std::shared_ptr<error::ErrorDatabaseMap>& global_error_database = |
Contributor
There was a problem hiding this comment.
This shouldn't be a reference, also auto can be used here.
lib/everest.cpp
Outdated
| for (const std::string& impl : Config::keys(this->module_manifest.at("provides"))) { | ||
| // setup shared database | ||
| std::shared_ptr<error::ErrorDatabaseMap> error_database = std::make_shared<error::ErrorDatabaseMap>(); | ||
| const std::shared_ptr<error::ErrorDatabaseMap> error_database = std::make_shared<error::ErrorDatabaseMap>(); |
lib/message_queue.cpp
Outdated
| { | ||
| const std::lock_guard<std::mutex> handlers_lock(handler_list_mutex); | ||
| for (auto handler : this->handlers) { | ||
| for (const auto& handler : this->handlers) { |
Contributor
There was a problem hiding this comment.
use local_handlers = this->handlers
Member
Author
There was a problem hiding this comment.
this->handlers is a unordered_set, so just a copy-assignment to the local_handlers vector doesn't work, that's probably why this is done this way
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
a-w50
approved these changes
Jan 8, 2025
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.