This repository was archived by the owner on Dec 9, 2025. It is now read-only.
Erase MessageHandler for topics without any registered handlers#229
Merged
hikinggrass merged 6 commits intomainfrom Jan 8, 2025
Merged
Conversation
This drastically reduces the amount of lingering threads just hanging around and doing absolutely nothing Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
a-w50
reviewed
Jan 7, 2025
lib/mqtt_abstraction_impl.cpp
Outdated
| if (!found) { | ||
| EVLOG_AND_THROW( | ||
| EverestInternalError(fmt::format("Internal error: topic '{}' should have a matching handler!", topic))); | ||
| EVLOG_warning << fmt::format("Internal error: topic '{}' should have a matching handler!", topic); |
Contributor
There was a problem hiding this comment.
This is not really an error, as is written in the comment, this is an valid but unlikely event.
Member
Author
There was a problem hiding this comment.
Changed to a verbose log and slightly reworded the comment
lib/mqtt_abstraction_impl.cpp
Outdated
| // only subscribe for this topic if we aren't already and the mqtt client is connected | ||
| // if we are not connected the on_mqtt_connect() callback will subscribe to the topic | ||
| if (this->mqtt_is_connected && this->message_handlers[topic].count_handlers() == 1) { | ||
| if (this->mqtt_is_connected && this->message_handlers.at(topic).count_handlers() == 1) { |
Contributor
There was a problem hiding this comment.
Seeing this the first time, why should count_handlers() == 1?
Member
Author
There was a problem hiding this comment.
I think that's because if count_handler == 1 after registering a new handler it was the first handler being registered which should then trigger a subscribe
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
a-w50
approved these changes
Jan 8, 2025
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
hikinggrass
deleted the
bugfix/prevent-lingering-threads-from-message-handler
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drastically reduces the amount of lingering threads just hanging around and doing absolutely nothing