This repository was archived by the owner on Dec 9, 2025. It is now read-only.
Merged
Conversation
Member
hikinggrass
commented
Jan 8, 2025
hikinggrass
commented
- Log module startup time for JavaScript and Python modules as well
- Log the number of modules started
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de> # Conflicts: # src/manager.cpp Signed-off-by: Kai-Uwe Hermann <kai-uwe.hermann@pionix.de>
a-w50
approved these changes
Jan 13, 2025
Comment on lines
+32
to
+36
| const auto end_time = std::chrono::system_clock::now(); | ||
| EVLOG_info << "Module " << fmt::format(Everest::TERMINAL_STYLE_BLUE, "{}", this->module_id) << " initialized [" | ||
| << std::chrono::duration_cast<std::chrono::milliseconds>(end_time - this->start_time).count() | ||
| << "ms]"; | ||
|
|
Contributor
There was a problem hiding this comment.
Not sure why this function needs to be defined in the header, should probably move to a cpp file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.