Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Revert "feature: add signal handler for termination"#237

Merged
a-w50 merged 1 commit intomainfrom
revert-236-feature/terminate_signal_handler
Jan 15, 2025
Merged

Revert "feature: add signal handler for termination"#237
a-w50 merged 1 commit intomainfrom
revert-236-feature/terminate_signal_handler

Conversation

@a-w50
Copy link
Contributor

@a-w50 a-w50 commented Jan 15, 2025

Reverts #236

  • using exit() for enforcing dumping the gcov statistics doesn't always work and has some other flaws
  • instead, __gcov_dump should be called in the handler, but this needs to be done in everest-core, as everest-framework shouldn't know if everest-core is built for code coverage

@a-w50 a-w50 requested a review from hikinggrass January 15, 2025 15:14
@hikinggrass
Copy link
Member

hikinggrass commented Jan 15, 2025

Needs a sign-off, git revert doesn't add that by default

@a-w50 a-w50 merged commit f0d3731 into main Jan 15, 2025
4 checks passed
@a-w50 a-w50 deleted the revert-236-feature/terminate_signal_handler branch January 15, 2025 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants