-
Notifications
You must be signed in to change notification settings - Fork 43
Fully Public Contracts #463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51281a3 to
9ad142f
Compare
2182cd0 to
ca6780a
Compare
…ops - these can be supported if fully public and we already have an error for the secret case
…ing if there is an external contract call
…hey don't interact with secret
…the function is public
…dition, trueBody and falseBody of an if statement are included instead of the new contract specific ones
…he db didn't exist
ca6780a to
bfb2e9d
Compare
SwatiEY
approved these changes
Dec 18, 2025
Contributor
|
Thanks! |
jtcoolen
approved these changes
Dec 18, 2025
|
🎉 This PR is included in version 1.10.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for fully public contracts and also fixes several bugs that occurred during testing of the ERC721.sol contract with the starlight compiler.