Python wrapper: create a path to executable within a separate function#13
Open
heavelock wants to merge 3 commits intoEarthScope:mainfrom
Open
Python wrapper: create a path to executable within a separate function#13heavelock wants to merge 3 commits intoEarthScope:mainfrom
heavelock wants to merge 3 commits intoEarthScope:mainfrom
Conversation
Signed-off-by: Damian Kula <heavelock@gmail.com>
Signed-off-by: Damian Kula <heavelock@gmail.com>
Signed-off-by: Damian Kula <heavelock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
Thanks for great additions to the project, last time I looked at it was in ~2020 so there were a few! Especially the json mode is great, it allowed me to remove hard dependency on mseedindex's DB schema in my app. Thanks Chad!
The change I am proposing is mostly due to the fact I am using mseedindex in my python app. I need to call it from python code via subprocess hence I need a path to a binary. I could rely on PATH but it feels quite fragile. Having a path delivered from the python package itself feels much cleaner.
I had to bump the version of mseedindex since the python package doesn't maintain its own ver.
What do you think?