Closed
Conversation
|
|
||
| public class FramerateCommand { | ||
|
|
||
| public static final IntSupplier MAX_REFRESH_RATE = () -> Minecraft.getInstance().virtualScreen.screenManager.monitors.values().stream() |
Owner
There was a problem hiding this comment.
Why not make this a method?
Collaborator
Author
There was a problem hiding this comment.
I intended to make it come across as a constant that only rarely changes.
Owner
There was a problem hiding this comment.
That's not a good reason to not use a method
Collaborator
Author
There was a problem hiding this comment.
What's wrong with a supplier though?
Collaborator
Author
|
Closed in favour of #726. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #711. The unlimited framerate cutoff is now increased to the maximum of the refresh rates of all connected monitors. This allows people to set their maximum framerate to a value possibly higher than
260, without effectively setting it to unlimited.