Skip to content

loading css back #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lazarusA merged 1 commit into from
Apr 4, 2026
Merged

loading css back #620

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions src/components/ui/css/Loading.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
.loading-container{
position: fixed;
top: 50%;
right: 50%;
transform: translate(50%, 50%);
z-index: 2;
}
Comment on lines +1 to +7
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The current CSS for .loading-container will not correctly center the element in the viewport. Using top: 50% and right: 50% with transform: translate(50%, 50%) offsets the element down and to the right of the center. To properly center it, you can use left: 50% and transform: translate(-50%, -50%), which is a more common and reliable method for centering.

Suggested change
.loading-container{
position: fixed;
top: 50%;
right: 50%;
transform: translate(50%, 50%);
z-index: 2;
}
.loading-container{
position: fixed;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
z-index: 2;
}


.loading{
background-color: var(--background-plot);
color: var(--text-plot);
padding: 3px 6px;
border-radius: 4px;
font-size: 24px;
font-weight: 700;
display: flex;
align-items: center;
gap: 6px;
}

.loading::after {
content: '';
width: 24px;
height: 24px;
border: 2px solid var(--text-plot);
border-top-color: transparent;
border-radius: 50%;
animation: spin 1s linear infinite;
}

.progress-bar{
left:0;
width: 100%;
height: 6px;
margin-top: 2px;
background-color: rgb(213, 219, 154);
border-radius: 3px;
box-shadow: 0px 0px 2px rgb(0, 0, 0);

}
Comment on lines +31 to +40
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The .progress-bar class uses hardcoded colors for background-color and box-shadow. This will not adapt to different themes (e.g., light/dark mode) defined in globals.css. You should use CSS variables for colors to ensure consistency with the application's design system. For example, you could use var(--accent-1) for the background and var(--accent-3) for the shadow.

Suggested change
.progress-bar{
left:0;
width: 100%;
height: 6px;
margin-top: 2px;
background-color: rgb(213, 219, 154);
border-radius: 3px;
box-shadow: 0px 0px 2px rgb(0, 0, 0);
}
.progress-bar{
left:0;
width: 100%;
height: 6px;
margin-top: 2px;
background-color: var(--accent-1);
border-radius: 3px;
box-shadow: 0px 0px 2px var(--accent-3);
}

Loading