Update API dates use timespan #85
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
Collaborator
Author
danlooo
added a commit
that referenced
this pull request
Feb 20, 2025
Collaborator
|
We have to fix DiskArrayTools |
felixcremer
reviewed
Feb 20, 2025
felixcremer
reviewed
Feb 20, 2025
felixcremer
reviewed
Feb 24, 2025
felixcremer
reviewed
Feb 24, 2025
Collaborator
|
This should be good to go. Let's see what CI will say. |
Collaborator
|
CI fails due to the DiskArrayTools failure. We should rebase this on the latest main |
danlooo
force-pushed
the
update_api_timespan
branch
from
b4f5540 to
2303981
Compare
Co-authored-by: @felixcremer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to clarify the CLI API and fix #78 . Previously,
rqatrendwas called for each year of a listyearsby implicitly adding half a year of buffer. Now, the time span to be analysed is given explicitly using argumentsstart_dateandend_dateof themainfunction. This allows for any arbitrary input time spans. Furthermore, this helps us in returning just one zarr array per call.