picker control cross-referencing#16
Open
ackspony wants to merge 1 commit intoEastDesire:masterfrom
ackspony:patch-1
Open
picker control cross-referencing#16ackspony wants to merge 1 commit intoEastDesire:masterfrom ackspony:patch-1
ackspony wants to merge 1 commit intoEastDesire:masterfrom
ackspony:patch-1
Conversation
The purposes of these changes are to facilitate different ways of manipulating / customizing the color picker control by CSS. 1. Set the class name 'jscolor-picker-control' in the picker control wrap so it can be targeted in CSS. 2. Generate a handle for picker instance and save it in the 'data-picker-handle' attribute in both the picker control wrap and callee for cross-reference. 3. Save the input element's "id" attribute in the 'data-picker-input-id' attribute, (should it have the "id" attribute) for cross-reference. 4. Save the input element's "class" attribute in the 'data-picker-input-class' attribute, (should it have the "class" attribute) for cross-reference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purposes of these changes are to facilitate different ways of manipulating / customizing the color picker control by CSS.
Set the class name 'jscolor-picker-control' in the picker control wrap so it can be targeted in CSS.
Generate a handle for picker instance and save it in the 'data-picker-handle' attribute in both the picker control wrap and callee for cross-reference.
Save the input element's "id" attribute in the 'data-picker-input-id' attribute, (should it have the "id" attribute) for cross-reference.
Save the input element's "class" attribute in the 'data-picker-input-class' attribute, (should it have the "class" attribute) for cross-reference.