-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Fix filters for Doctrine embedded class fields #4840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Simplify handling
|
No reply and pull request #4882 inserted into the milestone 4.x. I think a nested filter is not an efficient way because it breaks the logic of filters : it takes care about embedded class properties (mixed type) AND associations (the aim of the entity filter). Nevermind, the most important is to be able to use filters on embedded Doctrine classes: a very very very primary feature and without discuss about. |
|
Geat work! 👍 |
Fixes #4245
Explanations
This fix replaces dots by underscore internally in the form and filters collection without change anything else.
Limitations
foo.bar(embedded) andfoo_bar(not embedded), you might have some troubles.