Skip to content

Conversation

@Ang3
Copy link
Contributor

@Ang3 Ang3 commented Nov 28, 2021

Fixes #4245

Explanations
This fix replaces dots by underscore internally in the form and filters collection without change anything else.

Limitations

  • For Doctrine embedded classes only (no association support, maybe you could create a traversable filter to apply joins)
  • If you have two fields foo.bar (embedded) and foo_bar (not embedded), you might have some troubles.

@Ang3 Ang3 changed the title [Feature] Fix filters for embedded fields [3.x] Fix filters for embedded fields Nov 28, 2021
@Ang3 Ang3 changed the title [3.x] Fix filters for embedded fields Fix filters for embedded fields Dec 2, 2021
@Ang3 Ang3 changed the title Fix filters for embedded fields Fix filters for Doctrine embedded class fields Dec 2, 2021
@Ang3
Copy link
Contributor Author

Ang3 commented Dec 23, 2021

No reply and pull request #4882 inserted into the milestone 4.x.

I think a nested filter is not an efficient way because it breaks the logic of filters : it takes care about embedded class properties (mixed type) AND associations (the aim of the entity filter). Nevermind, the most important is to be able to use filters on embedded Doctrine classes: a very very very primary feature and without discuss about.

@ksn135
Copy link
Contributor

ksn135 commented Apr 3, 2023

Geat work! 👍
It's looks more solid then #4882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Filter by Embedded Doctrine Type

2 participants