Custom entity name representation for autocomplete #5189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexndlm
suggested changes
Apr 22, 2022
alexndlm
approved these changes
May 4, 2022
Lustmored
force-pushed
the
gh-3753
branch
2 times, most recently
from
5bb75aa to
625be33
Compare
javiereguiluz
added
feature
priority: important
Contributor
Author
|
I have rebased on master and fix CS and PHPStan validation. Documentation CI failure is not related to this PR |
|
Hi guys, I would like to see this PR in action. Why is there no progress here? If there are problems, I would like to fix them. |
|
I would also like to see this one being merged. |
|
@javiereguiluz is there any chance that this can be added to EA? |
Contributor
|
@Lustmored can you resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3753
This implements feature requested in #3753 in a way suggested within.
My one concern in backwards compatibility within
EntityPaginatorInterface. Not sure what to do here, possibly just write a note inUPGRADE.md?