Skip to content

Conversation

@emmanuel-averty
Copy link
Contributor

The tests jobs of my previous PR (#5555) failed with errors :

The service "doctrine.orm.default_annotation_metadata_driver" has a dependency on a non-existent service doctrine.orm.metadata.annotation_reader".

This PR replaces annotations by PHP 8 attributes.

This change allows tests to pass for PR #5555

(The actual code change in entities has been made by rector)

@javiereguiluz javiereguiluz added this to the 4.x milestone Jan 9, 2023
@javiereguiluz
Copy link
Collaborator

Thank you Emmanuel.

@javiereguiluz javiereguiluz merged commit b01fd47 into EasyCorp:4.x Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants