Closed
Conversation
Collaborator
Author
|
Tests are failing. I've been thinking about removing this cache warmer and reword its logic in other parts of the bundle. I'll try to submit a proposal about this. |
Collaborator
Author
|
Let's close this in favor of #6769, which will allow us to get rid of the cache warmer in version 5.0.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally made the cache warmer required because the application cannot work without this information. But, Nicolas recommended to make it optional, so let's do that. See symfony/symfony#59445 (comment)