Allow for custom routes to use EasyAdmin's context, especially in templates#6765
Merged
javiereguiluz merged 1 commit intoEasyCorp:4.xfrom Apr 12, 2025
Merged
Conversation
1ad1844 to
a514383
Compare
Contributor
|
powerful! |
Contributor
Author
|
Friendly ping @javiereguiluz : apparently this issue existed elsewhere, and this PR will actually fixes it 🚀 |
Collaborator
|
Thanks Alex! ... and sorry it took me so long to merge this. |
Contributor
|
Shouldn't this be included in the documentation, since it's now possible to use pretty URLs "globally"? https://symfony.com/bundles/EasyAdminBundle/current/actions.html#integrating-symfony-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if you create a normal Controller class and render a template that contains this code:
{% extends '@EasyAdmin/page/content.html.twig' %}You end up having this error:
An exception has been thrown during the rendering of a template ("Call to a member function getTemplatePath() on null").The reason for this bug is that there is no AdminContext set in the request, because the request is not served by a
DashboardControllerInterfacenor aCrudControllerInterface.Considering the fact that it's possible to create an AdminContext without a CrudController (makes sense, for the main page for example), as of the signature of the
AdminContextFactory::create()method:This PR allows doing things like this:
And since the
EA::DASHBOARD_CONTROLLER_FQCNRequest attribute is only set in routes generated by EasyAdmin, there should be no conflicts with the existing codebase or with existing admins around.And by doing so, you can create any controller and still use EasyAdmin's base templates 👌
Note: I'm using exactly this one-line change in one of my projects, so having this PR merged would be great 😁