Skip to content

Conversation

@Pierstoval
Copy link
Contributor

@Pierstoval Pierstoval commented May 7, 2025

Current roadmap:

  • Create basic setup within the Controller's edit action
  • Create specific template for field display
  • Create JS script to handle in-place edition
  • Handle the fetch part in JS
  • Handle the fetch part in the Crud controller
  • Make sure validation is used (needs Create InvalidEntityException to replace RuntimeException in EntityUpdater #6927)
  • Add support for more complex types
  • Convert all form data to multipart, to make sure it works with files
  • Get @javiereguiluz's feedback before moving on to the next elements of this list
  • Make thorough tests for all field types, including nested forms
  • Update the docs
  • Publish 🚀

@Pierstoval
Copy link
Contributor Author

@javiereguiluz I'm facing a particularly annoying structural issue.

I will have to display some forms in the index and detail pages.
But some fields, like CollectionField and others, require some Assets to be loaded.
These DTOs are configured using the onlyOnForms() method, which updates loadedOn in the final DTO, for its JS asset.

My initial idea was to update EA's index/detail page to load these assets manually when any field in the list contains an "edit in place" for this action. However, this might sound like a hack, but it would work in the end.

How would you do it?

@BenjaminBeck
Copy link

Maybe more something for the long run: Use lazy loading stimulus controller for all js

@Pierstoval
Copy link
Contributor Author

Pierstoval commented May 15, 2025

Maybe more something for the long run: Use lazy loading stimulus controller for all js

This wouldn't necessarily need Stimulus, but this would probably load unneeded JS in possibly all pages, and I want to avoid that, and prefer to load the JS code only when necessary.

@Pierstoval
Copy link
Contributor Author

Pierstoval commented May 16, 2025

So far, this is the current state on a pet project:

(Note: it works the same way on the detail page too)

ea_edit_in_place.mp4

Pierstoval added a commit to Orbitale/Conventionist that referenced this pull request May 16, 2025
@Pierstoval Pierstoval force-pushed the edit-in-place branch 2 times, most recently from cb9853c to 941747b Compare June 19, 2025 22:20
@Pierstoval Pierstoval marked this pull request as ready for review June 19, 2025 22:43
@Pierstoval
Copy link
Contributor Author

Friendly ping @javiereguiluz : I can still work on this, rebase & stuff, but can't do it if you don't agree about the sole existence of this feature :)

@Pierstoval Pierstoval force-pushed the edit-in-place branch 2 times, most recently from cd86bfc to 447c1e6 Compare January 6, 2026 14:21
@Pierstoval
Copy link
Contributor Author

If at some point you want to test, you can use this project: https://github.com/Orbitale/Conventionist/tree/edit-in-place , check the composer.json to symlink your installation of EasyAdmin with this edit-in-place branch (or you can checkout the PR with the gh cli, as you wish)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants