[BUG] fix(AdminUrlGenerator): unitialize before early returns #7220
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ! I noticed that trying to upgrade after 4.16.1 (and this commit I believe dc4bc4c ) while still not using pretty urls (we intend to, but it is a long journey ^^), some of the generated urls break.
For instance, the url for filter modal becomes
htps://localhost/admin?crudAction=renderFilters. Every other param disappears.I noticed that the previous generated url was one for the dashboard with then went trough this code bloc :
I figured the previous
AdminUrlGeneratorwas then not uninitialized, which might leak wrong params to the next generated url.This seems at least to fix my issue, but I might be missing something, WDYT ?