fix alpha-conversion problems in ehoare #872
Merged
+12
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskgo
requested changes
Jan 23, 2026
Contributor
oskgo
left a comment
oskgo
left a comment
There was a problem hiding this comment.
Can you get rid of the formatting changes and add regression tests? Other than that, looks good to me.
strub
force-pushed
the
fix-ehoare
branch
2 times, most recently
from
f1b6139 to
16e8fe3
Compare
oskgo
approved these changes
Jan 27, 2026
Contributor
Author
|
Thank.
B
… On 27 Jan 2026, at 21:07, oskgo ***@***.***> wrote:
@oskgo approved this pull request.
—
Reply to this email directly, view it on GitHub <#872 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFBT3FT6SGRLG2AMVMG3734I7ARTAVCNFSM6AAAAACSWGIWCKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTOMJTGIZTKNBZGM>.
You are receiving this because you authored the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.