feat(nginx-proxy): Add SSL_STAPLING env var to control OCSP stapling#299
Merged
mrrobot47 merged 1 commit intoEasyEngine:developfrom Jan 13, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes nginx warning logs by correcting the placement of the http2 directive and adding optional control for SSL stapling via environment variable.
Changes:
- Moved
http2 on;directive outside oflistenblocks to prevent duplication warnings in nginx 1.25.1+ - Added
SSL_STAPLINGenvironment variable to allow disabling OCSP stapling for certificates without OCSP support - Updated documentation to include the new
SSL_STAPLINGvariable
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| nginx-proxy/nginx.tmpl | Relocated http2 on; to server-level (3 locations) and added conditional SSL stapling based on SSL_STAPLING environment variable |
| nginx-proxy/README.md | Added documentation for the new SSL_STAPLING environment variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Add SSL_STAPLING environment variable (default: on) to allow disabling OCSP stapling for certificates without OCSP responder URLs. Usage: Set SSL_STAPLING=off on containers to silence the warning: 'ssl_stapling ignored, no OCSP responder URL in the certificate' This is useful for self-signed certificates or certificates from CAs that don't provide OCSP responder URLs.
e0b9765 to
bdabb6b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
SSL_STAPLINGenvironment variable to allow disabling OCSP stapling for certificates without OCSP responder URLs.Problem
Nginx logs warnings for certificates that don't have OCSP responder URLs:
This is common with self-signed certificates or certificates from CAs that don't provide OCSP.
Solution
Add
SSL_STAPLINGenvironment variable (default:on) that can be set tooffto disable OCSP stapling.Usage
Changes
SSL_STAPLINGenv var support with conditional check before enabling ssl_stapling