Conversation
Refactor attributes to fetch from self, the parent class, the config, in that order
victoryftw
approved these changes
May 8, 2017
Contributor
victoryftw
left a comment
victoryftw
left a comment
There was a problem hiding this comment.
This seems good to me. This functionality is pretty important in my mind, since wanting to separate production/test mode queues comes up a lot.
Contributor
att14
reviewed
May 9, 2017
lib/easy_stalk/job.rb
Outdated
| keys | ||
| end | ||
| end | ||
| def self.get_serializable_context_keys |
Contributor
There was a problem hiding this comment.
Why aren't these instance methods?
Contributor
|
I changed a bunch of the attrs to use instance method where I thought it made sense (i.e. the ones that seemed job-scope configurable). We might be able to do the same for retry_attempts, but it seemed like the "job" that we actual dequeue in |
Member
|
Still needed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently Jobs didn't support multi level inheritance as jake was hoping they would. this fixes inherited attributes from a parent job class (EXCEPT tube name)