Android: Fix common crashes / various improvements#3321
Merged
carstene1ns merged 9 commits intoEasyRPG:masterfrom Jan 8, 2025
Merged
Android: Fix common crashes / various improvements#3321carstene1ns merged 9 commits intoEasyRPG:masterfrom
carstene1ns merged 9 commits intoEasyRPG:masterfrom
Conversation
Member
Ghabry
commented
Jan 3, 2025
Ghabry
commented
- Bumped the SDK so Google will annoy us one year later about SDK updates ;)
- Fixed crashes existing since 0.8 (none of them was critical but good to have them resolved)
- Most crashes are related to the settings becoming null because the app restarts, I was able to simulate this and hopefully fixed it everywhere (by adding a new class which does this automatically)
- After a game crash the game list was empty, fixed this by refetching the easyrpgURI (which was also null...)
- Fixed a crash when opening the settings while another scene was currently opening (race condition)
- Fixed crashes reported after the latest APK update
- Fixed a crash in the new "sorting" option when the game list was empty
- Upon feedback the Z/X buttons are reverted back to A/B buttons but the setting is still available, just a different default
- Standalone mode fixes
Same behaviour as the presets
…re more common by now
Is the base class instead of AppCompatActivity. If not applicable the SettingsManager call was manually added. Fixes null pointer exceptions when the app restarts.
…to a crash) easyRPGFolder becomes null and must be refetched
…ser feedback The option to change it is still available
ghost
approved these changes
Jan 4, 2025
carstene1ns
approved these changes
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.