Map: initialize screen width and height on SetupCommon#3328
Merged
Ghabry merged 1 commit intoEasyRPG:masterfrom Jan 14, 2025
Merged
Map: initialize screen width and height on SetupCommon#3328Ghabry merged 1 commit intoEasyRPG:masterfrom
Ghabry merged 1 commit intoEasyRPG:masterfrom
Conversation
Member
|
I think I deleted this because I assumed Setup is always called 🤔. Have to check the control flow 😅. Thanks |
Member
|
@aidatorajiro I checked this now and Can you try deleting the screen_width = (Player::screen_width / 16.0) * SCREEN_TILE_SIZE;
screen_height = (Player::screen_height / 16.0) * SCREEN_TILE_SIZE;from |
torahappy
changed the title
ghost
added
the
Maps
ghost
approved these changes
Jan 13, 2025
Otherwise the initialization is not applied when loading a Savegame Fix EasyRPG#3327
Ghabry
force-pushed
the
patch-map-init
branch
from
a2473b1 to
179ecbf
Compare
Ghabry
approved these changes
Jan 14, 2025
Member
Ghabry
left a comment
Ghabry
left a comment
There was a problem hiding this comment.
Squashed all commits into one as the intermediate commits were unnecessary here. Otherwise no changes from my side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3327.
(i don't know how this patch interferes with #3293, but Init() is called only after reset, so not a very destructing change i guess)