Add config option allowing map loader to prefer RPG Maker files#3491
Merged
carstene1ns merged 1 commit intoEasyRPG:masterfrom Jan 5, 2026
Merged
Add config option allowing map loader to prefer RPG Maker files#3491carstene1ns merged 1 commit intoEasyRPG:masterfrom
carstene1ns merged 1 commit intoEasyRPG:masterfrom
Conversation
carstene1ns
approved these changes
Dec 17, 2025
Member
carstene1ns
left a comment
There was a problem hiding this comment.
Seems a valuable addition for developers at least.
Though exposing this in the UI is debatable IMHO.
The end user does not benefit from this and can be confused.
Contributor
Author
|
Completely agree. To clarify, it is not exposed in the UI. I am not sure what is missing from this PR that is causing it to not appear in the UI, but I guess it's a happy accident that it does not appear. |
Member
|
To make it appear you must add it in window_settings.cpp but I agree that it is better to not show it |
Member
|
Could you rename |
Contributor
Author
|
Done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new boolean to the player config:
PreferEasyRpgMapFiles(default:true)This makes the map loader attempt to load EasyRPG map files first, and fall back to RPG Maker map files on errors. Since it defaults to
true, this PR retains the existing behavior of the EasyRPG Player, which attempts to load EasyRPG map files first.I just wanted a way to turn this behavior off in my game, as it creates issues with my VCS setup (essentially, a pre-commit hook that runs lcf2xml on all the files in the project).
QA steps I tried:
1(true) in config:Error: Loading of Map Map0001.lmu failed.-- notice it loaded the .lmu last) ✅0(false) in config:Error: Loading of Map Map0001.emu failed.-- notice it loaded the .emu last) ✅1) ✅